-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bindings/python): add python 3.10 back and remove pypy #5347
Conversation
3ea5e9f
to
1ed0c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trim21 for this change, mostly LGTM, only some minor changes.
@@ -150,6 +150,8 @@ services-upyun = ["opendal/services-upyun"] | |||
services-vercel-artifacts = ["opendal/services-vercel-artifacts"] | |||
services-yandex-disk = ["opendal/services-yandex-disk"] | |||
|
|||
abi3 = ["pyo3/abi3-py311"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment on what this feature control and why we need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trim21 to add this!
Which issue does this PR close?
#5335
Closes #5335
Rationale for this change
build cp310 wheel with non-abi3 flags
What changes are included in this PR?
Are there any user-facing changes?
no