refactor(core): MaybeSend does not need to be unsafe #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
02-remove-unsafe
branch
from
d50fea9
to
ae34736
Compare
Xuanwo
changed the title
Xuanwo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Remove
unsafefrom traitunsafe trait MaybeSendCloses #.
Rationale for this change
A safe trait provides the same functionality as its unsafe counterpart but requires no safety guarantees from the implementor, making the unsafe keyword unnecessary.
What changes are included in this PR?
Remove
unsafefrom the trait declaration.Are there any user-facing changes?
This change is backward compatible