Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/python): add sync File.readline #5271

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

TennyZhuang
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Better compatibility with Python builtin open behavior.

What changes are included in this PR?

Add File.readline API in Python binding

Are there any user-facing changes?

Add File.readline API in Python binding

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TennyZhuang for implementing this!

@Xuanwo Xuanwo merged commit aa94e83 into apache:main Nov 2, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants