feat(services/ftp): List dir shows last modified timestamp #5213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4746.
What changes are included in this PR?
ftp service will also return last modified timestamp.
Are there any user-facing changes?
Nope.
Questions
I found other problems that I want to change but they are not part of the issue.
I also found the underlying crate
suppaftp
supports async. I want to support it. This might be a breaking change for FTP service. Do you consider support async for ftp?I also see sftp implementation uses another crate
openssh_sftp_client
. I have skimmed through these crates documentation and code. I don't want to expand this comparasion too much. In short,suppaftp
depends tls implementation in Rust whileopenssh_sftp_client
depends on OpenSSH.suppaftp
has slightly less code. I am considering usingsuppaftp
if that fulfill the current implementation. Happy to discuss more.I tested this locally by using a FTP server in Docker. Roughly put, how much tests do you consider to have and where to start?