Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove version suffix from package versions #4254

Merged
merged 4 commits into from
Feb 23, 2024
Merged

ci: Remove version suffix from package versions #4254

merged 4 commits into from
Feb 23, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 23, 2024

No description provided.

Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 23, 2024

I don't know why python on nextcloud keeps failling..

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 23, 2024

I don't know why python on nextcloud keeps failling..

cc @hoslo, seems related to webdav changes, would you like to take a look?

@oowl
Copy link
Member

oowl commented Feb 23, 2024

Why do we remove these suffixes? it seems the last PR has added these suffixes. #4246

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 23, 2024

Why do we remove these suffixes? it seems the last PR has added these suffixes. #4246

  • Some platforms like python can't publish.
  • And I realized that the core version of rust packages is not true. Users could use opendal 0.45.2 for oay 0.0.1+core.0.45.1 which adds more confusion.

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 23, 2024

I don't know why python on nextcloud keeps failling..

Created #4255 to track it.

@Xuanwo Xuanwo merged commit f6a161b into main Feb 23, 2024
165 of 170 checks passed
@Xuanwo Xuanwo deleted the fix-build branch February 23, 2024 05:04
@tisonkun
Copy link
Member

I remember we have a consensus to add this suffix; when we decided to remove it?

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 16, 2024

I remember we have a consensus to add this suffix; when we decided to remove it?

Those suffix never exists in the releases (just in Cargo.toml). We can remove them now.

@tisonkun
Copy link
Member

I mean: we decide to add them, and when we dedide to revert the previous decision?

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 16, 2024

I mean: we decide to add them, and when we dedide to revert the previous decision?

We abort this change during 0.45.1 release that we found registry like pypi, npm doesn't accept those tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants