feat(icloud): Add basic Apple iCloud Drive support #3980

bokket · 2024-01-15T03:35:16Z

part #2627
passed in local.

Signed-off-by: bokket <[email protected]>

JasCodes · 2024-01-15T03:38:13Z

@bokket Awesome effort, hope this gets merged

bokket · 2024-01-15T03:44:40Z

@bokket Awesome effort, hope this gets merged

just achieve Read and state method.write need upload is a little complicated.Maybe can make up next month

Xuanwo · 2024-01-15T04:00:03Z

Hi, please install typos and make our types check happy first.

core/src/services/icloud/client.rs

core/src/services/icloud/backend.rs

Xuanwo · 2024-01-15T04:15:10Z

core/src/services/icloud/session.rs

+const AUTH_HEADERS: [(&str, &str); 7] = [
+    (
+        "X-Apple-OAuth-Client-Id",
+        "d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d",


Where does this key come from?

ref:https://github.com/picklepete/pyicloud/blob/master/pyicloud/base.py#L392C1-L392C1

Please add in comments so the maintainer knows where it's from.

core/src/services/icloud/session.rs

core/src/services/mod.rs

Xuanwo · 2024-01-15T04:18:46Z

Hi, please install typos and make our types check happy first.

If hsa is not a typo, please add it into the ignore list with comment to explain it.

Signed-off-by: bokket <[email protected]>

bokket · 2024-01-15T17:41:52Z

Hi, please install typos and make our types check happy first.

If hsa is not a typo, please add it into the ignore list with comment to explain it.

Looks well, let's continue?

Signed-off-by: bokket <[email protected]>

.typos.toml

core/src/services/icloud/backend.rs

core/src/services/icloud/core.rs

core/src/services/icloud/drive.rs

Signed-off-by: bokket <[email protected]>

Xuanwo · 2024-01-16T14:58:14Z

Hi, path cache has been added in main, maybe you want to refactor by it instead?

bokket · 2024-01-16T15:02:49Z

Hi, path cache has been added in main, maybe you want to refactor by it instead?

Let me briefly review path_cache

bokket · 2024-01-17T10:45:02Z

icloud will only list the directory, so we need to let the path_cache support to return parent_id instead of not only returning self_id.
The current cache : path->parent_id,return self_id.
The refactored cache: path->self_id,return self_id.The interface insert is not exposed.

parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:a5e90ada-46b4-4f83-ae75-3fe1bce01ca3
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:Some("FILE::com.apple.CloudDocs::3DE26BDF-DC8F-4DDA-98C0-24E52F75587C") | name:normal_file.txt
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:Some("FILE::com.apple.CloudDocs::468C2835-A0BF-4C7A-B615-FE939C0C9A36") | name:special_file  !@#$%^&()_+-=;',.txt
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:73a1d5b6-d023-47f7-ac96-6362b2217925
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:fff769a8-132e-48ca-b3ec-5b18d4237530
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:ba3996a2-8c0c-4b42-a65b-e8f1bb0efc15
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/
parent_id:FOLDER::com.apple.CloudDocs::root| path_cache:None | name:f610d966-0256-468b-88ad-5d49098a5321/

I want to customize the cache of Insert format

Xuanwo · 2024-01-17T10:58:15Z

icloud will only list the directory, so we need to let the path_cache support to return parent_id instead of not only returning self_id.

I'm confused. To find the parent of a/b/c or a/b/d/, can't we simply look up the ID of a/b/?

bokket · 2024-01-17T11:36:07Z

icloud will only list the directory, so we need to let the path_cache support to return parent_id instead of not only returning self_id.

I'm confused. To find the parent of a/b/c or a/b/d/, can't we simply look up the ID of a/b/?

Ok. I don’t know why / is an extra layer of uuid directory below, puts me into a misunderstanding.

Signed-off-by: bokket <[email protected]>

core/src/services/icloud/drive.rs

core/src/services/icloud/client.rs

core/src/services/icloud/core.rs

core/src/services/icloud/backend.rs

core/src/services/icloud/client.rs

core/src/services/icloud/core.rs

core/src/services/icloud/drive.rs

Signed-off-by: bokket <[email protected]>

Xuanwo

Thanks a lot! Some details could be polished in later PRs.

Xuanwo · 2024-01-19T03:46:01Z

Hello @bokket, could you address the conflicts?

Signed-off-by: bokket <[email protected]>

bokket · 2024-01-19T04:07:43Z

Hello @bokket, could you address the conflicts?

I solved manually.

feat:Add Apple iCloud Drive support

5747e1e

Signed-off-by: bokket <[email protected]>

bokket requested review from Xuanwo and PsiACE as code owners January 15, 2024 03:35

github-actions bot added the releases-note/feat label Jan 15, 2024

cargo fmt

24a835d

Signed-off-by: bokket <[email protected]>

Xuanwo reviewed Jan 15, 2024

View reviewed changes

bokket added 6 commits January 16, 2024 00:13

Merge branch 'main' of github.com:apache/incubator-opendal into main

47d8310

add some docs

5b37b5a

Signed-off-by: bokket <[email protected]>

cargo fmt

5a621f4

Signed-off-by: bokket <[email protected]>

add response json test

4df6b11

Signed-off-by: bokket <[email protected]>

fmt

dad592d

Signed-off-by: bokket <[email protected]>

modify typos.toml

230876d

Signed-off-by: bokket <[email protected]>

add env.example region

2f25383

Signed-off-by: bokket <[email protected]>

Xuanwo reviewed Jan 16, 2024

View reviewed changes

bokket added 4 commits January 16, 2024 18:18

Merge branch 'main' of github.com:apache/incubator-opendal into main

45ad927

use is_china_mainland instead region

d1711a6

Signed-off-by: bokket <[email protected]>

fmt

d000f5b

Signed-off-by: bokket <[email protected]>

make clippy happy

e419146

Xuanwo changed the title ~~feat(iCloud):Add Apple iCloud Drive support~~ feat(icloud): Add basic Apple iCloud Drive support Jan 16, 2024

Merge branch 'main' of github.com:apache/incubator-opendal into main

b75b3bd

bokket added 2 commits January 18, 2024 01:16

Merge branch 'main' of github.com:apache/incubator-opendal into main

131cd41

refactor path_cache trait

6c94ae9

Signed-off-by: bokket <[email protected]>

bokket mentioned this pull request Jan 17, 2024

feat: Add iCloud Drive/Photo support #2627

Open

1 task

Xuanwo reviewed Jan 17, 2024

View reviewed changes

core/src/services/icloud/drive.rs Outdated Show resolved Hide resolved

bokket added 5 commits January 18, 2024 09:53

refactor dir struct

8fe102c

Signed-off-by: bokket <[email protected]>

fmt

ef4fee5

Signed-off-by: bokket <[email protected]>

remove Useless comment

40fc0a5

Signed-off-by: bokket <[email protected]>

Merge branch 'main' of github.com:apache/incubator-opendal into main

1fdb8d0

delete dead code

572d7c9

Signed-off-by: bokket <[email protected]>

Xuanwo approved these changes Jan 19, 2024

View reviewed changes

bokket added 2 commits January 19, 2024 11:55

merge upstream

9ce244e

Signed-off-by: bokket <[email protected]>

fix conflicts

8ce7511

Signed-off-by: bokket <[email protected]>

Xuanwo merged commit 980f25b into apache:main Jan 19, 2024
189 checks passed

Zheaoli mentioned this pull request Jan 19, 2024

chore: Bump to version 0.44.2 to start release process #4028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(icloud): Add basic Apple iCloud Drive support #3980

feat(icloud): Add basic Apple iCloud Drive support #3980

bokket commented Jan 15, 2024 •

edited

Loading

JasCodes commented Jan 15, 2024

bokket commented Jan 15, 2024

Xuanwo commented Jan 15, 2024

Xuanwo Jan 15, 2024

bokket Jan 15, 2024

Xuanwo Jan 16, 2024

Xuanwo commented Jan 15, 2024 •

edited

Loading

bokket commented Jan 15, 2024

Xuanwo commented Jan 16, 2024

bokket commented Jan 16, 2024

bokket commented Jan 17, 2024 •

edited

Loading

Xuanwo commented Jan 17, 2024 •

edited

Loading

bokket commented Jan 17, 2024

Xuanwo left a comment

Xuanwo commented Jan 19, 2024

bokket commented Jan 19, 2024 •

edited

Loading

feat(icloud): Add basic Apple iCloud Drive support #3980

feat(icloud): Add basic Apple iCloud Drive support #3980

Conversation

bokket commented Jan 15, 2024 • edited Loading

JasCodes commented Jan 15, 2024

bokket commented Jan 15, 2024

Xuanwo commented Jan 15, 2024

Xuanwo Jan 15, 2024

Choose a reason for hiding this comment

bokket Jan 15, 2024

Choose a reason for hiding this comment

Xuanwo Jan 16, 2024

Choose a reason for hiding this comment

Xuanwo commented Jan 15, 2024 • edited Loading

bokket commented Jan 15, 2024

Xuanwo commented Jan 16, 2024

bokket commented Jan 16, 2024

bokket commented Jan 17, 2024 • edited Loading

Xuanwo commented Jan 17, 2024 • edited Loading

bokket commented Jan 17, 2024

Xuanwo left a comment

Choose a reason for hiding this comment

Xuanwo commented Jan 19, 2024

bokket commented Jan 19, 2024 • edited Loading

bokket commented Jan 15, 2024 •

edited

Loading

Xuanwo commented Jan 15, 2024 •

edited

Loading

bokket commented Jan 17, 2024 •

edited

Loading

Xuanwo commented Jan 17, 2024 •

edited

Loading

bokket commented Jan 19, 2024 •

edited

Loading