Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement path cache and refactor gdrive #3975

Merged
merged 26 commits into from
Jan 16, 2024
Merged

feat: Implement path cache and refactor gdrive #3975

merged 26 commits into from
Jan 16, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 12, 2024

No description provided.

@Xuanwo
Fix gdrive build
e5803ba 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix build
2cf48b8 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix tests
51cccc4 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix list
ad9d819 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix gdrive
9055bf9 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save work
6612086 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo marked this pull request as draft January 12, 2024 10:55
@Xuanwo
Refactor
bb6b0c1 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
FIx path cache
887ed66 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Merge branch 'main' into path-cache
bb0b507
@Xuanwo
Update cache after write file
c1c019a 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Update cache with list result
c8aafab 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Introduce lock for path cache
ae2f6f9 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix ensure path
8a0845a 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix build
3eaa330 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix build
53f0670 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
ignore empty path
5543e40 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Make sure ensure_path is guard by lock
03371dd 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix build
2fa0921 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
FIx deadlock
b4e0ef3 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix assert
41b5d7d 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix path
d32def9 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix rename
fc096ee 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 16, 2024

I've fixed numerous bugs in the current drive implementation; apologies for not being able to split them into multiple PRs.

@Xuanwo Xuanwo marked this pull request as ready for review January 16, 2024 11:50
suyanhanx
suyanhanx reviewed Jan 16, 2024
View reviewed changes
core/src/raw/path_cache.rs Outdated Show resolved Hide resolved
core/src/raw/path_cache.rs Outdated Show resolved Hide resolved
core/src/raw/path_cache.rs Outdated Show resolved Hide resolved
core/src/raw/path_cache.rs Outdated Show resolved Hide resolved
core/src/raw/path_cache.rs Outdated Show resolved Hide resolved
core/src/services/gdrive/backend.rs Outdated Show resolved Hide resolved
@Xuanwo
Fix typo
227f1d1 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Polish
9f783e3 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested a review from suyanhanx January 16, 2024 14:25
suyanhanx
suyanhanx approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit f6ddb8e into main Jan 16, 2024
227 checks passed
@Xuanwo Xuanwo deleted the path-cache branch January 16, 2024 14:55
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
@imWildCat imWildCat mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imWildCat imWildCat imWildCat left review comments

@suyanhanx suyanhanx suyanhanx approved these changes

@Young-Flash Young-Flash Awaiting requested review from Young-Flash

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @imWildCat @suyanhanx