-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services): add hdfs native layout #3933
Conversation
@Xuanwo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, we can begin our journey now!
Hi, we need to address this error: error[E0631]: type mismatch in function arguments
--> core/src/services/hdfs_native/backend.rs:190:22
|
190 | .map_err(new_std_io_error)?;
| ------- ^^^^^^^^^^^^^^^^ expected due to this
| |
| required by a bound introduced by this call
|
::: core/src/raw/std_io_util.rs:27:1
|
27 | pub fn new_std_io_error(err: std::io::Error) -> Error {
| ----------------------------------------------------- found signature defined here
|
= note: expected function signature `fn(hdfs_native::HdfsError) -> _`
found function signature `fn(std::io::Error) -> _` We can implement a |
Sure will take care of it |
Hi, please make sure previous commits pass the CI before adding 9e34b5f. You can return an unsupported error instead. |
I think it's best to merge the layouts first, then add the detailed implementations. |
Sure, let me revert this change. |
Let's address the CI issues individually, particularly those found at https://github.com/apache/incubator-opendal/actions/runs/7541144383/job/20527241562?pr=3933. First of all, running |
6171833
to
6e76a0b
Compare
Should I push |
Yes. Changes to lock file should also be committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rock!
@Xuanwo Thank you so much for your patience and guidance 🙇 |
Have fun! |
For #3144