Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add behavior tests for blocking buffer reader #3872

Merged
merged 2 commits into from
Dec 31, 2023
Merged

feat: add behavior tests for blocking buffer reader #3872

merged 2 commits into from
Dec 31, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 31, 2023

  1. Expose buffer method on FunctionReader
  2. Add behavior tests for blocking buffer reader

Related

#3735

@WenyXu WenyXu requested a review from Xuanwo as a code owner December 31, 2023 05:30
@WenyXu WenyXu mentioned this pull request Dec 31, 2023
Closed
11 tasks
Xuanwo
Xuanwo approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@Xuanwo Xuanwo merged commit 035b3dc into apache:main Dec 31, 2023
190 checks passed
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenyXu @Xuanwo