Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bindings/cpp): add CONTRIBUTING.md #2984

Merged
merged 7 commits into from
Aug 31, 2023
Merged

docs(bindings/cpp): add CONTRIBUTING.md #2984

merged 7 commits into from
Aug 31, 2023

Conversation

silver-ymz
Copy link
Member

Update:

  • add CONTRIBUTING.md
  • add address sanitizer to check memory error
  • fix memory overflow in Operator::read

Xuanwo
Xuanwo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, please feel free to merge this PR when you are ready.

@silver-ymz silver-ymz merged commit c5b6177 into main Aug 31, 2023
19 checks passed
@silver-ymz silver-ymz deleted the cpp-contribute-docs branch August 31, 2023 08:08
This was referenced Sep 1, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silver-ymz @Xuanwo