Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure blob support #165

Merged
merged 23 commits into from
Mar 24, 2022
Merged

add azure blob support #165

merged 23 commits into from
Mar 24, 2022

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented Mar 21, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

I have finish basic functions of supporting azblob for opendal and stripe authing function from azure sdk for rust into reqsign repo. Now you can write read delete stat object in azure in behavior tests But I don't know how to wrap list_object response into stream.

Points to note:

  • acc::list() is Not yet realized
  • have redirected cargo.toml dependency to my repo
  • Comment out the test listing paragraph in here so behavior tests can pass

@Xuanwo
Copy link
Member

Xuanwo commented Mar 21, 2022

  • acc::list() is Not yet realized

It's OK to keep going on, let's implement other functions first.

  • have redirected cargo.toml dependency to my repo

We need to wait for the next release of reqsign with azure support.

  • Comment out the test listing paragraph in here so behavior tests can pass

We can implement the test after azblob is ready.

@D2Lark
Copy link
Contributor Author

D2Lark commented Mar 22, 2022

  • acc::list() is Not yet realized

It's OK to keep going on, let's implement other functions first.

Good, I am interested in this issue, let me try

@Xuanwo
Copy link
Member

Xuanwo commented Mar 22, 2022

Good, I am interested in this issue, let me try

So nice! Please do it in a new PR so that we can do it in parallel.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 23, 2022

reqsign v0.0.2 has been released: Xuanwo/reqsign#40 🏁

Let's come back to this PR!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work! Mostly LGTM, I left some review on small details, PTAL.

.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
opendal_test/src/services/azblob.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
tests/behavior/behavior.rs Outdated Show resolved Hide resolved
@D2Lark
Copy link
Contributor Author

D2Lark commented Mar 24, 2022

I leave tests module unchange and refine the azblob module. After I finish list object func then I will create another PullRequest

@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2022

Looks so nice! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants