Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fs): skip seek if offset is 0 #1082

Merged
merged 2 commits into from
Dec 17, 2022
Merged

feat(fs): skip seek if offset is 0 #1082

merged 2 commits into from
Dec 17, 2022

Conversation

yang-han
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

closing #1056 , avoid seek if offset is 0

@Xuanwo Xuanwo changed the title chore(fs): skip seek if offset is 0 feat(fs): skip seek if offset is 0 Dec 17, 2022
Xuanwo
Xuanwo reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM to me, can you also update the usage in blocking_read?

@yang-han
Copy link
Contributor Author

Mostly LGTM to me, can you also update the usage in blocking_read?

ok, done

@yang-han yang-han requested a review from Xuanwo December 17, 2022 13:52
Xuanwo
Xuanwo approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Xuanwo Xuanwo merged commit be87536 into apache:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yang-han @Xuanwo