Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Trunk demo errors in error log (OFBIZ-13005) #748

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

PierreSmits
Copy link
Member

HumanRes - EmployeeScreens.xml: remove reference to non-existing form ListEmployeeQualification
SFA - EventForm.xml: convert form to grid, a form cannot extend a grid
Order - CommonScreens.xml: adding context-param requestMenuLocation, used also in other applications
Order - CommonScreens.xml: changing location of request menus (parameterized)
Order - CustRequestScreens.xml: changing location of request menus (parameterized)

Thanks: @JacquesLeRoux for reporting this issue

Given that request screens are used as portal pages, the inclusion of such portal pages in other applications leads to errors being thrown for the associated menus (due to the use of the mainMenuLocation parameter in web.xml).
Having a requestMenuLocation in web.xml solves this issue.

modified:
- web.xml: add contextParam requestMenuLocation
- CommonScreens.xml: change location request related menus
- CustRequestScreens.xml: change location request related menu
modified:
EmployeeScreens.xml - removed form reference to grid ListEmployeeQualification
modified: EventForms.xml - MyTaks: extending a grid
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JacquesLeRoux JacquesLeRoux merged commit 6039526 into apache:trunk Apr 9, 2024
6 checks passed
@JacquesLeRoux
Copy link
Contributor

Thanks Pierre

@PierreSmits
Copy link
Member Author

Thanks Jacques,

for helping me to help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants