Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv7-a/r:cp15_invalidate_dcache_all: fix Sets mask error. #5354

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

zhuyanlinzyl
Copy link
Contributor

As NumSets field is bits 13-27, use 0x7fff instead.
And add way to get from CCSIDR.

Summary

Impact

No, bug fix

Testing

As NumSets field is bits 13-27, use 0x7fff instead.
And add way to get from CCSIDR.
@xiaoxiang781216 xiaoxiang781216 merged commit 4d5c258 into apache:master Jan 27, 2022
@masayuki2009
Copy link
Contributor

@zhuyanlinzyl @xiaoxiang781216
Humm, sabre-6quad:smp with QEMU does not boot now.

If I revert this PR it works again.
Could you confirm what is happening with QEMU?

@zhuyanlinzyl
Copy link
Contributor Author

zhuyanlinzyl commented Jan 28, 2022

hi, @masayuki2009.

I build sabre-6quad:smp and try in QEMU, but it still hang without this patch.

Did I use the wrong command, Can you share the shell command with me?

$ qemu-system-arm -M sabrelite -kernel nuttx -nographic

@masayuki2009
Copy link
Contributor

masayuki2009 commented Jan 28, 2022

@zhuyanlinzyl

Did I use the wrong command, Can you share the shell command with me?

Please refer the following link
https://github.com/apache/incubator-nuttx/blob/b0d24f53c4be391f2e0081ef4bba4f5058e54f9e/boards/arm/imx6/sabre-6quad/README.txt#L643

NOTE: If you just start the qemu without GDB, you can remove -s -S options.

@zhuyanlinzyl
Copy link
Contributor Author

hi, @masayuki2009

It's my mistake, a4 register not save in cp15_invalidate_dcache_all.

I fixed it in PR #5367

I verify in sabre-6quad:smp build. You can have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants