task_exit.c: Add missing sched_note_stop() #14483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: OS Components
xiaoxiang781216
approved these changes
Oct 23, 2024
A regression from apache#13728 ; sched_note_stop() is never called for tasks that exit normally via exit().
pussuw
force-pushed
the
exit_sched_note
branch
from
c33d5a8
to
c5c7375
Compare
jerpelea
approved these changes
Oct 23, 2024
acassis
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that sched_note_stop() is never called for tasks that exit normally. This patch fixes a regression from #13728 ; there is a missing call to sched_note_stop() in task_exit().
Impact
Fixes the scheduler instrumentation when a task exits. Nothing else is affected.
Testing
Private MPFS target with sched note driver.