Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support fchstat and chstat function for littlefs" #14479

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Oct 23, 2024

Reverts #13964

because:

  • it seems to introduce some regressions. i saw fstat failing with ENOENT on files on an image generated with https://github.com/jrast/littlefs-python.
  • we should reduce the amount of the local patches. not the opposite. if you want to extend littlefs, please upstream it first.
  • it's controversial if it's a good idea to waste on-disk structures for attributes like file modes and uid/gid, which nuttx doesn't really support.

@github-actions github-actions bot added Area: File System File System issues Size: M The size of the change in this PR is medium labels Oct 23, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 23, 2024

[Experimental Bot, please feedback here]

Based on the provided description, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary: The PR only states it reverts a previous change. It lacks information on the necessity of the revert, affected code, and how the revert addresses the issue.
  • Impact: Reverting a change can have significant impact. The PR needs to address all impact points, specifying which areas are affected by the revert and how.
  • Testing: While mentioning "Testing logs before change" and "Testing logs after change", the PR provides no actual logs. Concrete evidence of testing both before and after the revert is crucial.

Recommendation:

The PR needs significant revisions to meet NuttX requirements. The author should provide:

  1. Detailed Summary: Explain why Add support fchstat and chstat function for littlefs #13964 needs reverting, what functionalities are impacted, and how the revert addresses the original PR's issues.
  2. Thorough Impact Analysis: Analyze and describe the revert's impact on all mentioned aspects (user, build, hardware, documentation, security, compatibility).
  3. Concrete Testing Evidence: Include actual testing logs from before and after the revert to demonstrate the change's effectiveness.

@yamt yamt marked this pull request as ready for review October 23, 2024 09:32
@xiaoxiang781216
Copy link
Contributor

can we add an option to make the new feature selectable?

@yamt
Copy link
Contributor Author

yamt commented Oct 24, 2024

can we add an option to make the new feature selectable?

it's possible. but it's better to remove it for now, IMO.
adding more and more local patches like this here makes the use of different versions of littlefs impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: File System File System issues Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants