-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpmsg_sockif: add some modifaction for rpsocket #14118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
Effects networking subsystem
Size: S
The size of the change in this PR is small
labels
Oct 11, 2024
[Experimental Bot, please feedback here] NuttX PR Requirements ReviewThis PR does not meet the NuttX requirements. Here's why:
To improve this PR:
By providing a comprehensive summary, outlining the impact, and including detailed testing information, you'll make it easier for reviewers to understand and approve your PR. |
github-actions
bot
added
Size: M
The size of the change in this PR is medium
and removed
Size: S
The size of the change in this PR is small
labels
Oct 11, 2024
yintao707
changed the title
rpmsg_sockif: add rpmsg_socket_ept_release for free conn
rpmsg_sockif: add some modifaction for rpsocket
Oct 11, 2024
yintao707
force-pushed
the
release_conn
branch
3 times, most recently
from
October 12, 2024 11:51
6e6f0c5
to
c867e6f
Compare
Signed-off-by: yintao <[email protected]>
Signed-off-by: Xiang Xiao <[email protected]>
Signed-off-by: Xiang Xiao <[email protected]>
1.Simplify the message process in rpmsg_socket_send_single 2.Add more lock protection in rpmsg socket 3.Fix the style issue Signed-off-by: Xiang Xiao <[email protected]>
expand the user's rpname size hash when exceed RPMSG_SOCKET_NAME_LEN due to the limitation of eptname Signed-off-by: yintao <[email protected]>
yintao707
force-pushed
the
release_conn
branch
from
October 12, 2024 13:01
c867e6f
to
2a11440
Compare
xiaoxiang781216
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
add rpmsg_socket_ept_release for free connection
to Fix possible use-after-free issues when closing
sendsize should be protected by sendlock
remove backlog=-1 because patch1 has removed
Minor cleanups
Simplify the message process in rpmsg_socket_send_single and fix the style issue
use hash to handle rp_name
expand the user's rpname size
hash when exceed RPMSG_SOCKET_NAME_LEN due to the limitation of eptname
Impact
none
Testing
sim