Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Bp-13878} sim bug fix #13968

Merged
merged 5 commits into from
Oct 9, 2024
Merged

{Bp-13878} sim bug fix #13968

merged 5 commits into from
Oct 9, 2024

Conversation

jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Oct 9, 2024

Summary

sim bug fix:
sim: fix context-switch when do wdog callback()
sim/gcov: Fix conflicts between fprofile-orderate and __asan_default_options
arch/sim: dataheap should disable exec permission
arch/sim: fix uart could lose log

Impact

RELEASE

Testing

CI

GUIDINGLI and others added 5 commits October 9, 2024 09:10
@GUIDINGLI @jerpelea
sim: fix context-switch when do wdog callback()
3d90478 
Signed-off-by: ligd <[email protected]>
@Gary-Hobson @jerpelea
Revert "arch/sim: suppress libasan checks"
61e8d52 
This reverts commit 53ddc3e

Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: ligd <[email protected]>
@Gary-Hobson @jerpelea
sim/gcov: Fix conflicts between fprofile-orderate and __asan_default_…
ca49009 
…options

Signed-off-by: yinshengkai <[email protected]>
@xiaoxiang781216 @jerpelea
arch/sim: dataheap should disable exec permission
581b0fa 
Signed-off-by: Xiang Xiao <[email protected]>
@XuNeo @jerpelea
arch/sim: fix uart could lose log
14b2b39 
Need to loop to write untill all data written or error happened

Signed-off-by: xuxingliang <[email protected]>
@github-actions github-actions bot added Arch: simulator Issues related to the SIMulator Size: S The size of the change in this PR is small labels Oct 9, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

This PR appears incomplete based on the NuttX requirements. Here's why:

  • Summary Lacks Detail:
    • "sim bug fix" is too vague. Be specific about what bug is fixed and how it's fixed in each commit.
    • Provide a brief explanation of what functional areas are affected (e.g., watchdog timer, memory management, UART driver).
  • Impact Is Under-Described:
    • RELEASE suggests this is a critical bug fix. Provide specific details about the impact:
      • What breaks without this fix?
      • What are the consequences of the bugs being fixed?
    • While CI testing is good, it's not sufficient. You must provide:
      • Build Host Information: Your OS, compiler, etc.
      • Target Details: Which simulator configurations did you test (e.g., sim:nsh)?
      • Testing Logs: "Before" and "after" logs are essential to demonstrate the fix.

Recommendation: Expand on the provided information to meet the NuttX PR requirements for a thorough review.

@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 9, 2024

apache/nuttx-apps#2661 needed

@xiaoxiang781216 xiaoxiang781216 merged commit b63826a into apache:releases/12.7 Oct 9, 2024
10 of 29 checks passed
@jerpelea jerpelea deleted the bp-13878 branch October 9, 2024 10:35
@jerpelea jerpelea mentioned this pull request Oct 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
Arch: simulator Issues related to the SIMulator Size: S The size of the change in this PR is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jerpelea @nuttxpr @xiaoxiang781216 @GUIDINGLI @Gary-Hobson @XuNeo