-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] When building nuttx-apps
, CI Workflow checks out the Incorrect Branch of nuttx
repo
#14513
[BUG] When building nuttx-apps
, CI Workflow checks out the Incorrect Branch of nuttx
repo
#14513
Comments
Update: We should never apply this fix to
In Future: We should always backport the Latest CI Jobs |
When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: apache#14513 This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: apache/nuttx#14513 This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
Hi @lupyuen yes, I think so too that there is a typo due to this change github actions maybe after coming out of the 30/10 tunnel it would be better to create a workflow release with everything (docker, macos, msys2 and msvc) |
Thanks @simbit18! Yep let's reorg the CI Workflow after 30 Oct. I'm keen to hear your ideas, maybe you can share an outline of the proposed workflow? Thanks :-) |
Description / Steps to reproduce the issue
When compiling the Release Branch of
nuttx-apps
, our CI Workflownuttx-apps/build.yml
checks out the Master Branch ofnuttx
repo, which is incorrect: {Bp-2655} examples: fix noteprint compile error nuttx-apps#2770 (comment)This comes from the arm-05 log: https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069572079#step:7:96
This happens because
mps3-an547:bl
doesn't exist in thereleases/12.7
branch. (It exists inmaster
)Fetch-Source Log shows that CI is indeed checking out the Master Branch of
nuttx
repo (instead ofreleases/12.7
): https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069568370#step:3:66Which might be caused by a typo in
nuttx-apps/build.yml
: https://github.com/apache/nuttx-apps/blob/master/.github/workflows/build.yml#L92The workflow above says we are checking out Branch
os_ref
. Butos_ref
is undefined! It's actually namedname
: https://github.com/apache/nuttx-apps/blob/master/.github/workflows/build.yml#L85I propose to change
name
toos_ref
:Tracking back to the original code: It seems plausible that there's a typo: https://github.com/apache/nuttx/pull/9289/files
Suspiciously became:
Note the
apps_ref
vsapp_ref
. I patched it toapps_ref
(which needs to be backported toreleases/12.7
ofnuttx-apps
)In our Test Repo for
nuttx-apps
: Changingname
toos_ref
seems to work OK: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11528123257/job/32094821811#step:3:57Hi @simbit18: Do you agree with my findings? Do you think it will cause issues in the NuttX Repo when we change
name
toos_ref
? Thanks!On which OS does this issue occur?
[OS: Linux]
What is the version of your OS?
CI Workflow
NuttX Version
master
Issue Architecture
[Arch: all]
Issue Area
[Area: Other]
Verification
The text was updated successfully, but these errors were encountered: