treewide: silent download, unpack and others #1630
Conversation
This introduces changes from NuttX commits: 03b164f59ce40a3f5677b0588af2aee8d9697bf6 7fef3e48e6092a59e58b541ef62bdd5f2f600b61 The only left out is 'Register:' as that provides pretty handly list of applications in the firmware. The download is unified to handle it always the same way.
|
Please, wait with merge. There seems to be issues with downloading wamr. I have to look into it. |
|
@Cynerd please let me know: does this PR hides the Downloading and Patching lines? I think it is important to users know that the files are downloaded during the building phase. |
|
I agree. it is critical to know that a build cannot be completed while staying offline. |
I agree also. It is definitely critical to know that things are being downloaded. Wherever we are doing a download, we should also allow a custom URL in Kconfig, so that developers who want to locally host the dependencies will be able to do so. |
You can mark the PR as Draft until ready for review. That will prevent someone merging by mistake... |
|
Hi @Cynerd maybe a better approach is just show: Downloading: filename-x.y.z and when it finishes download: done. What do you think? |
|
@Cynerd could you fix the conflict? |
|
I will look at this next week. This is pretty old and was created only to keep it consistent in my eyes with the rest of the changes introduced at that time. I think that it still makes sense in terms of echoing that the download is happening but not in the way of reporting its progress. In the meantime, we also modified the build process of our own projects in a way that nothing is being downloaded, and thus, I had less incentive to deal with this. |
Agree! All user friendly improvements are welcome! |
This introduces changes from NuttX commit
03b164f59ce40a3f5677b0588af2aee8d9697bf6.
The only left out is 'Register:' as that provides pretty handly list of applications in the firmware.
The download is unified to handle it always the same way.
Follow up on #1588 (comment).