NIFI-13720: Component is not reloaded when the isolation key depends on service property #9236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turcsanyip
reviewed
Sep 10, 2024
.../nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java
Outdated
Show resolved
Hide resolved
turcsanyip
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Thanks for the fix @mark-bathori!
+1 LGTM
@markap14 Do you have any other idea to overcome the issue mentioned in the PR summary? (other than restructuring the system tests module)
To be able to create a system test for the PR the system-test-extension had to be restructured because when a component is annotated with @RequiresInstanceClassLoading and contains a controller service property then the framework does not allow the component to be in the same bundle as the service API.
|
Merging to main. @markap14 Feel free to add your notes on this system tests module change later on and we can adjust it in a follow-up jira. Thanks |
ravinarayansingh
pushed a commit
to ravinarayansingh/nifi
that referenced
this pull request
Oct 1, 2024
…on service property This closes apache#9236. Signed-off-by: Peter Turcsanyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To be able to create a system test for the PR the system-test-extension had to be restructured because when a component is annotated with @RequiresInstanceClassLoading and contains a controller service property then the framework does not allow the component to be in the same bundle as the service API.
NIFI-13720
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation