Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13210 Add CODECOV_TOKEN to GitHub Workflow #8808

Closed
wants to merge 1 commit into from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-13210 Adds the CODECOV_TOKEN secret reference to the Codecov reporting step in the GitHub workflow, enabling code coverage reporting following Apache infrastructure updates in INFRA-25778.

Codecov Action version 4 requires a token for coverage reporting.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Set Codecov action to be conditional based on running in the context of the Apache organization
@exceptionfactory
Copy link
Contributor Author

The Codecov action completed and reported results as expected.

https://app.codecov.io/github/apache/nifi/pull/8808

@asfgit asfgit closed this in 5f9f524 May 10, 2024
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
- Set Codecov action to be conditional based on running in the context of the Apache organization

Signed-off-by: Pierre Villard <[email protected]>

This closes apache#8808.
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
- Set Codecov action to be conditional based on running in the context of the Apache organization

Signed-off-by: Pierre Villard <[email protected]>

This closes apache#8808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants