MINIFICPP-2485 fix: Support Expression Language in InvokeHTTP "Remote URL" property

[lordgamez]

https://issues.apache.org/jira/browse/MINIFICPP-2485

---

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically main)?

• Is your initial contribution a single, squashed commit?

For code changes:

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file?
• If applicable, have you updated the NOTICE file?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

[adamdebreceni]

since we are rotating a single element each time I think an std::list with splice would be clearer, also I think we should replace the clients_created_ with std::list::size to act as a single source of truth

[lordgamez]

Could you elaborate a bit on this, please? How would you use the splice with std::list in a way that would replace the rotate function?

We were also discussing using an std::list instead of the std::vector previously with @szaszm and I don't remember why we decided against it. @szaszm can you maybe remember?

[adamdebreceni]

#include <list>
#include <algorithm>
#include <vector>
#include <iostream>

int main() {
  // std::rotate(
  //   clients_.begin() + gsl::narrow<int64_t>(i),
  //   clients_.begin() + gsl::narrow<int64_t>(i + 1),
  //   clients_.begin() + gsl::narrow<int64_t>(clients_created_)
  // )
  std::list<int> clients{1, 2, 3, 4};
  for (auto it = clients.begin(); it != clients.end(); ++it) {
    if (*it == 2) {
      clients.splice(clients.end(), clients, it);
      break;
    }
  }
  std::cout << "after rotateLeft\n";  // 1, 3, 4, 2
  for (auto& val : clients) {
    std::cout << val << std::endl;
  }

  clients = std::list<int>{1, 2, 3, 4};
  // rotateRight(
  //   clients_.begin() + last_unused + 1,
  //   clients_.begin() + gsl::narrow<int64_t>(i) + 1,
  //   1
  // );
  clients.splice(std::next(clients.begin(), 1), clients, std::next(clients.begin(), 2));

  std::cout << "after rotateRight\n";  // 1, 3, 2, 4
  for (auto& val : clients) {
    std::cout << val << std::endl;
  }
}

[adamdebreceni]

I don't think it brings any performance benefits or things like that (I don't imagine we will have more than a handful of cached clients so the linear scanning works just fine), just that IMO it is a better fit to how we are actually using this container