MINIFICPP-2376 Add support for parameter context inheritance #1888
Conversation
| void StructuredConfiguration::verifyNoInheritanceCycles() const { | ||
| std::unordered_set<std::string> visited_parameter_contexts; | ||
| std::unordered_set<std::string> current_stack; | ||
| for (const auto& [parameter_context_name, parameter_context] : parameter_contexts_) { | ||
| if (hasInheritanceCycle(*parameter_context, visited_parameter_contexts, current_stack)) { | ||
| throw std::invalid_argument("Circular references in Parameter Context inheritance are not allowed. Inheritance cycle was detected in parameter context '" + parameter_context->getName() + "'"); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd add a timeout here, in the unlikely case we need to walk wide and deep inheritance trees and find long cycles, because the complexity of this check seems O(scary) with the recursion in hasInheritanceCycle.
Alternatively, we could put a hard limit on the number of contexts, or the number of inheritance levels, so the runtime of this algorithm becomes more predictable and manageable.
There was a problem hiding this comment.
I'm not sure this requires a timeout or any restriction. The cycle detection run a depth-first search algorithm which has linear complexity based on the number of parameter contexts, so it should not be running that long even for large number of parameter contexts. But I suppose even in flows where parameter contexts could be generated, like using a parameter provider that would generate parameters based on file hierarchies the number of contexts should only be in the 1000s at most which would still not cause a problem with algorithm.
lordgamez
force-pushed
the
MINIFICPP-2376
branch
from
54a69d0 to
a248075
Compare
lordgamez
force-pushed
the
MINIFICPP-2376
branch
from
a248075 to
a29feb9
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2376
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.