MINIFICPP-2294 Flow migration #1850
Conversation
martinzink
force-pushed
the
migrate_flow
branch
2 times, most recently
from
810d7e2 to
9bdde2f
Compare
martinzink
force-pushed
the
migrate_flow
branch
from
9bdde2f to
57f87b1
Compare
martinzink
force-pushed
the
migrate_flow
branch
from
57f87b1 to
134ad17
Compare
martinzink
force-pushed
the
migrate_flow
branch
from
134ad17 to
f7f0fe3
Compare
|
I would close this until we figure out how to do it in a C2-friendly way |
|
my mistake, I misunderstood parts of the PR. Apparently migrations are unversioned, idempotent, so they run on all input flow definitions, regardless of whether that was meant to target older or newer minifi versions. This way it's not a problem if we don't know what minifi version is targeted by the C2 server. I'm still not sure if an unversioned approach is the right one, but it's not inherently bad, like I thought an hour ago. |
| SECTION("Adaptive Yaml Configuration") { | ||
| core::flow::AdaptiveConfiguration adaptive_configuration(test_controller.getContext()); | ||
| auto root_flow_definition = adaptive_configuration.getRootFromPayload(std::string{ORIGINAL_YAML}); | ||
| REQUIRE(root_flow_definition); | ||
| serialized_flow_definition = adaptive_configuration.serialize(*root_flow_definition); | ||
| } |
There was a problem hiding this comment.
Do we need to test this in the scope of this feature? As far as I see the flow migration logic doesn't impact how the AdaptiveConfiguration recognizes the flow format, so testing the yml and json configuration separately should be enough.
There was a problem hiding this comment.
Good point removed it in a8b7f94
-Removed deprecated "Send Body" and "Disable Peer Verification" properties from InvokeHTTP -Removed deprecated "Message Key Field" property from PublishKafka -Removed deprecated SSL related properties from PublishKafka and replaced them with a generated SSLContextService
martinzink
force-pushed
the
migrate_flow
branch
from
f7f0fe3 to
bed1541
Compare
-Removed deprecated "Send Body" and "Disable Peer Verification" properties from InvokeHTTP
-Removed deprecated "Message Key Field" property from PublishKafka
-Removed deprecated SSL related properties from PublishKafka and replaced them with a generated SSLContextService
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.