Fix NetBeans launch failure on unix shell for arguments with quotes et al #7908
+100
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t al
**Issue**
When NetBeans is launched on *nix shell with arguments that contain
special characters like quotes, spaces, $ and backticks, then it may
fail or not receive the arguments correctly.
The launcher scripts are:
- java/java.lsp.server/script/bin/nbcode
- platform/o.n.bootstrap/launcher/unix/nbexec
The cause is due to incomplete escaping of the special characters before
quoting the argument.
**Fix**
1. Ensure that all arguments are quoted before passing forward to the
executable launch.
- This is implemented similar to other open-source build tools.
- Example: [ant](https://github.com/apache/ant/blob/master/src/script/ant#L63)
2. Ensure that the special characters ' " $ ` in the argument are
escaped according to the quoting being performed.
3. Consistently use `eval` with arguments single-quoted and parameter
substitution within it being double-quoted.
- This makes `nbexec` similar to the `nbcode` script
4. Updated the unit test for `nbexec`
Signed-off-by: Siddharth Srinivasan <[email protected]>
mbien
added
LSP
|
@neilcsmith-net - Please review this PR whenever its possible for you, and provide any suggestions for it. Thank you. |
|
@neilcsmith-net, @mbien - Please review this PR whenever earliest its possible for you, along with any suggestions for improvement. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When NetBeans is launched on *nix shell with arguments that contain special characters like quotes, spaces, $ and backticks, then it may fail or not receive the arguments correctly.
The launcher scripts are:
The cause is due to incomplete escaping of the special characters before quoting the argument.
Examples:
--jdkhome "$HOME/openjdk's jdkhome"--jdkhome '/home/user/tools/jdk "23"'--jdkhome /c/Program\ Files/Java/jdk--userdir "/mnt/user's macbook pro/Users/user/Library/Application Support/NetBeans"-Dnetbeans.extra.dirs="nb-dev\$old/extras/plugin1:nb-dev\$old/extras/plugin2:ext/My Plugins/quo\"'d"Further, a discrepancy is created between the argument strings passed on a Windows host (using the launcher exe/dll) and *nix hosts.
Fix
evalwith arguments single-quoted and parameter substitution within it being double-quoted.nbexecsimilar to thenbcodescriptnbexec.