#7606: process daemon's stdout to avoid lockup

[sdedic]

Accidentally (try-and-error) I discovered that when the daemon's output stream is not processed, the daemon hangs on reading the stdin even though stdin is empty. So I've attached the piped output stream + reading daemon unconditionally, so that gradle daemon correctly processes the empty stdin.

Closes #7606.

After testing, this can be eventually cherrypicked to delivery if @ebarboni agrees.

[mbien]

After testing, this can be eventually cherrypicked to delivery if @ebarboni agrees.

this would need to target delivery right away. We can't cherry pick from master since this would cause it to show up in the release notes of two releases.

also if we test / review, we should test it on the delivery branch, not the master branch which diverged already and then switch last minute.

[ebarboni]

@sdedic would be perfect based on delivery

[mbien]

@sdedic can you a) rebase this to delivery and change target and milestone, or b) confirm that this is meant for NB 24

there is some confusion since the issue has still NB 23 milestone.

[sdedic]

yes, I can rebase it if the issue is seen as "want fix" in NB23.

[ebarboni]

If it's ok for you lets do this.

[sdedic]

Rebased onto delivery, milestone changed.

[ebarboni]

LGTM, not the best gradle user but no issue for me

[mbien]

just as general comment since this PR is linked to close the issue: the infinite loop during priming would have to be addressed separately. A loop is not a good failure mode, it should be caught somewhere / propagated and stop with an error.

[sdedic]

just as general comment since this PR is linked to close the issue: the infinite loop during priming would have to be addressed separately. A loop is not a good failure mode, it should be caught somewhere / propagated and stop with an error.

The user reported an infinite loop. Are you sure that there's an infinite loop in fact ? What I saw during debugging / investigation was not a infinitely repeated attempt to load a project, but rather a stuck project load, that blocks all other loads (all gradle project loads are serialized to a RP).

[mbien]

@sdedic the user mentioned several times that the symptom was an "infinite loop" e.g. #7606 (comment)

I haven't tried to reproduce the original issue so I don't know.

[sdedic]

@sdedic the user mentioned several times that the symptom was an "infinite loop" e.g. #7606 (comment)

I haven't tried to reproduce the original issue so I don't know.

OK, I'll perhaps leave this open for someone to investigate more. I could not reproduce anything that actually is a loop. The user might be mistaken and mislead by the fact that a message "loading..." was stuck in the status line indefinitely, or the report might be incaccurately worded, but I cannot prove it and will not bother to prove the otherwise.

[lkishalmi]

Run a minimal test with this one. Gradle Daemons tends to get stuck after exiting the IDE. It seem this one has helped on that as well.

[ebarboni]

merging this. waiting for sync pr and baking rc3