Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.c/.h/.hpp files: Register WhereUsedAction and RenameAction in correct mime paths #7689

Merged

Conversation

matthiasblaesing
Copy link
Contributor

Closes: #7686

@matthiasblaesing matthiasblaesing added C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Aug 20, 2024
@matthiasblaesing matthiasblaesing added this to the NB24 milestone Aug 20, 2024
@Marisa-Chan
Copy link

Thanks! I prepare another, more correct patch, but it's already done correct!

@matthiasblaesing matthiasblaesing changed the base branch from master to delivery August 21, 2024 17:11
@matthiasblaesing matthiasblaesing modified the milestones: NB24, NB23 Aug 21, 2024
@matthiasblaesing
Copy link
Contributor Author

@lahodaj @vieiro given, that this is a trivial typo fix, I think it would be a candidate for NB23. Could you please have a look?

@Marisa-Chan yeah - in your issue report you indicated, that you don't plan to create a PR, so I had a look.

Could you please check the nightly build available from the checks page (or directly: https://github.com/apache/netbeans/suites/27439737814/artifacts/1838598363)?

For the timeframe: I retargetted this to delivery, if review can be done in time, this might(!) make it into NB23

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense (was clearly a copy/paste issue).

Not tested, but I agree this would be a good candidate for NB 23 due to low risk of side effects.

@vieiro
Copy link
Contributor

vieiro commented Aug 27, 2024

Hi @matthiasblaesing , I think @jlahoda is more knowledgeable on the cpplite cluster modules than I am.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@ebarboni ebarboni merged commit 65e9c8a into apache:delivery Sep 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPPLite does not provide "Find usage" and "Rename" for headers
6 participants