Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundant cast warnings #7552

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

BradWalker
Copy link
Member

Reduce redundant cast warnings. These happen as a side result of code cleanup..

Reduce warnings that look like this:

[repeat] /home/bwalker/src/netbeans/enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java:271: warning: [cast] redundant cast to LogViewer
[repeat] contextLog = (LogViewer)contextLogViewers.get(moduleID);
[repeat] ^Cleanup redundant casts. These are a side effect of work done doing code cleanup.

… cleanup..

Reduce warnings that look like this:

   [repeat] /home/bwalker/src/netbeans/enterprise/tomcat5/src/org/netbeans/modules/tomcat5/util/LogManager.java:271: warning: [cast] redundant cast to LogViewer
   [repeat]         contextLog = (LogViewer)contextLogViewers.get(moduleID);
   [repeat]                      ^Cleanup redundant casts. These are a side effect of work done doing code cleanup.
@BradWalker BradWalker added this to the NB23 milestone Jul 7, 2024
@BradWalker BradWalker self-assigned this Jul 7, 2024
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@BradWalker BradWalker merged commit d66c5df into apache:master Jul 8, 2024
32 checks passed
@BradWalker BradWalker deleted the cleanup_redundant_casts branch July 8, 2024 02:55
@mbien
Copy link
Member

mbien commented Jul 8, 2024

when you do project wide refactorings you have to let all tests run

@BradWalker
Copy link
Member Author

I thought I had done that..
Where did should I have been looking?
BTW, my apologies. I'm a little rusty this days. 8-)

@mbien
Copy link
Member

mbien commented Jul 8, 2024

ci:all-tests [ci] enable all tests enables all tests which is useful for project wide cleanup PRs or changes which could affect multiple areas of the IDE.

the CI section of https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide has more details and screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants