Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further JavaEE -> JakartaEE fixes for Jakarta Faces #7539

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Further JavaEE -> JakartaEE fixes for Jakarta Faces #7539

merged 2 commits into from
Jul 16, 2024

Conversation

matthiasblaesing
Copy link
Contributor

@matthiasblaesing matthiasblaesing commented Jul 2, 2024 •
edited
Loading

  • JSF Templates need to take into account new namespace schema for Jakarta Faces 4+
  • Detected CDI 1.1+ also on Jakarta CDI

Closes: #7532

@matthiasblaesing
JSF Templates need to take into account new namespace schema for Jaka…
cd5484c 
…rta Faces 4+

In the past the core namespaces for JSF were named:

http://xmlns.jcp.org/jsf/<core|facelets|html>

And in templates "http://xmlns.jcp.org" was pulled out as $nsLocation.
(JSF namespace changed from 2.1 to 2.2).

With JSF 4 another namespace change was enforced as part of the
donation. The namespaces are now named:

jakarta.faces.<core|facelets|html>

This needs to be considered by templates.
@matthiasblaesing
Detected CDI 1.1+ also on Jakarta CDI
bc70903 
The class used as inidicator for CDI 1.1+ moved from 

javax.enterprise.inject.spi.AfterTypeDiscovery

to

jakarta.enterprise.inject.spi.AfterTypeDiscovery
@matthiasblaesing matthiasblaesing added Java EE/Jakarta EE [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 2, 2024
@matthiasblaesing matthiasblaesing added this to the NB23 milestone Jul 2, 2024
@matthiasblaesing matthiasblaesing mentioned this pull request Jul 2, 2024
Closed
@matthiasblaesing
Copy link
Contributor Author

I plan to merge this sometime next week. If anyone wants to object, please do so now.

juneau001
juneau001 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@juneau001 juneau001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good...sorry for the delay in reviewing.

@matthiasblaesing
Copy link
Contributor Author

@juneau001 thanks for checking!

@matthiasblaesing matthiasblaesing merged commit 0d9ea57 into apache:master Jul 16, 2024
32 checks passed
@matthiasblaesing matthiasblaesing deleted the jakarta_fixes2 branch July 21, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juneau001 juneau001 juneau001 approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java EE/Jakarta EE [ci] enable enterprise job
Projects
NetBeans JavaEE related
Status: Done
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

Some jsf wizards are completely messed up
2 participants
@matthiasblaesing @juneau001