Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE #7170 #7425

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Prevent NPE #7170 #7425

merged 1 commit into from
Jun 4, 2024

Conversation

junichi11
Copy link
Member

@junichi11
Prevent NPE apache#7170
68b4950 
- apache#7170
- Add a `null` check
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jun 1, 2024
@junichi11 junichi11 added this to the NB23 milestone Jun 1, 2024
@junichi11
Copy link
Member Author

Just check null although I can't reproduce this issue.

@junichi11 junichi11 linked an issue Jun 1, 2024 that may be closed by this pull request
PHP code template insertion fails and empties the line #7170
Closed
@junichi11 junichi11 requested a review from tmysik June 2, 2024 22:49
@junichi11 junichi11 merged commit fb457ad into apache:master Jun 4, 2024
33 checks passed
@junichi11 junichi11 deleted the php-gh-7170-code-template-npe branch June 4, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

PHP code template insertion fails and empties the line
2 participants
@junichi11 @tmysik