Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deleting the nullable type prefix when the "fix imports" is run #7123 #7421

Conversation

junichi11
Copy link
Member

Example

/**
 * @property ?GH7123_01     $test_1
 * @property GH7123_01|null $test_2
 */
class GH7123_01{}

Before:

/**
 * @property GH7123_01     $test_1
 * @property GH7123_01|null $test_2
 */
class GH7123_01{}

After:

/**
 * @property ?GH7123_01     $test_1
 * @property GH7123_01|null $test_2
 */
class GH7123_01{}

apache#7123

- apache#7123
- Ignore the part of the nullable type prefix
- Add/Fix unit tests
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label May 30, 2024
@junichi11 junichi11 added this to the NB23 milestone May 30, 2024
@junichi11 junichi11 linked an issue May 30, 2024 that may be closed by this pull request
@junichi11 junichi11 requested a review from tmysik June 2, 2024 22:50
@junichi11 junichi11 merged commit 64451ec into apache:master Jun 4, 2024
38 checks passed
@junichi11 junichi11 deleted the php-gh-7123-fix-imports-with-nullable-types branch June 4, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in PHP "?" being auto removed from typehinting
2 participants