Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK Configuration action for VS Code #7414

Merged
merged 1 commit into from
May 30, 2024

Conversation

jisedlac
Copy link
Contributor

Action to configure a user-selected JDK installation for various VS Code features and settings (like JDK for NBLS, JDK for PATH in integrated Terminal, etc.) in a single step.

@dbalek dbalek requested review from lahodaj and dbalek May 29, 2024 08:24
@dbalek dbalek added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels May 29, 2024
@dbalek dbalek added this to the NB23 milestone May 29, 2024
@dbalek dbalek added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label May 29, 2024
@apache apache locked and limited conversation to collaborators May 29, 2024
@apache apache unlocked this conversation May 29, 2024
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks.

java/java.lsp.server/vscode/src/extension.ts Outdated Show resolved Hide resolved
java/java.lsp.server/vscode/src/jdk/configuration.ts Outdated Show resolved Hide resolved
@jisedlac jisedlac force-pushed the jisedlac/lsp-jdk-configuration branch 2 times, most recently from 9bf6e57 to 43217d9 Compare May 30, 2024 09:52
@jisedlac jisedlac force-pushed the jisedlac/lsp-jdk-configuration branch from 43217d9 to 272fa90 Compare May 30, 2024 12:22
@dbalek dbalek merged commit f328c4b into apache:master May 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants