Allow focus events to propagate before running glyph gutter actions - GH4155 #7386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… propagate before running actions.
neilcsmith-net
added
kind:bug
matthiasblaesing
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thank you, looks sane to me.
For me this fixes the issue, that two clicks are necessary if the target editor not yet has focus when setting a breakpoint. In my test not fixed by this is the issue of the "Toogle Bookmark" action covered by #7384.
|
No further update from the issue reporter. I'll merge this tomorrow unless anyone has objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #4155 breakpoints are added at the wrong point when clicking on the glyph gutter of an unfocused editor split. The glyph gutter mouse listener attempts to focus the editor component, but the focus change events are queued causing
EditorContextDispatcherto report the wrong focused component.Attempt to fix by checking if the component has the focus, and if not queuing up the event handling to run after the focus events.