Restructured node_modules license and package.json Validation Logic #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules Signed-off-by: Achal Talati <[email protected]>
matthiasblaesing
added
license
VSCode Extension
|
Looks good to me. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues encountered with the
prepareModulesclass's validation of licenses andpackage.jsonfiles. Presently, the function only scans the top-level directory, leading to occasional false error reports. Additionally, whenever a new dependency is introduced, it necessitates separate handling due to the potential presence of subdirectories containing relevantpackage.jsonand license information.To enhance generalization and streamline the process of adding new dependencies, the code has been refactored accordingly.