Improved Toolbar overflow impl. #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
UI
|
this is for NB 22 so no hurry |
|
oops. I assigned this PR by mistake instead of requesting review. |
eirikbakke
approved these changes
Jul 17, 2024
The overflow handling is now in doLayout() and runs when invalidate() was called instead of listening to resize events. Misc impl improvements.
|
cool! going to rebase the commit ontop of latest master to get a fresh CI run |
mbien
force-pushed
the
overflow-toolbar-fixes
branch
from
523d8c9
to
ba84e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overflow handling is now in
doLayout()and runs wheninvalidate()was called instead of listening to resize events. See #7000 (comment)Misc impl improvements: fewer array copies and the toolbar should be rebuilt less often.
fixes #7000