Breakpoints in Scala sources in VSCode #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you may know I am working on mixed Java+Scala codebase. I have developed a NetBeans
.nbmextension as well as.vsixfile to support our sbt based projects.There is a special ToggleScalaBreakpointActionProvider that handles breakpoints in Scala sources. It works great in NetBeans IDE. But I'd like it to work in VSCode as well!
This PR copies the code from ToggleScalaBreakpointActionProvider (the license is Apache and I wrote it, so I can do it) and places it to
java.lsp.server. That's not modular at all - but theActionProviderdoesn't seem to be consulted by thejava.lsp.server- should that be fixed, I happily host my code in my enso4igv extension.@entlicher, how do we move foward? There is not much modularity in the
java.lsp.serverdebugger breakpoint support - Java, Groovy, Truffle is all handled at a single place - can we add.scalaas well? Or shall we seek a complete refactor and find a way to invokeActionProvider.toggleBreakpointaction even from VSCode extension?