Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Code Folding and empty Arrays #7187

Closed
NReib opened this issue Mar 25, 2024 · 0 comments · Fixed by #7398
Closed

[PHP] Code Folding and empty Arrays #7187

NReib opened this issue Mar 25, 2024 · 0 comments · Fixed by #7398
Assignees
@junichi11
Labels
enhancement PHP [ci] enable extra PHP tests (php/php.editor)
Milestone
NB23

Comments

@NReib
Copy link

NReib commented Mar 25, 2024

Apache NetBeans version

Apache NetBeans 21

What happened

I am using the Option "collapse by default" for Arrays in Folding tab of NB options. This automatically folds all arrays, including empty arrays which makes editing them quite challenging.
I think it is not necessary to fold empty arrays.

Language / Project Type / NetBeans Component

No response

How to reproduce

Turn on folding for arrays

$foo = [];

Did this work correctly in an earlier version?

No / Don't know

Operating System

Mageia 8 (Linux)

JDK

javac 11.0.17

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No
@NReib NReib added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Mar 25, 2024
@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 25, 2024
@junichi11 junichi11 self-assigned this May 22, 2024
@junichi11 junichi11 added enhancement and removed kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels May 22, 2024
@junichi11 junichi11 added this to the NB23 milestone May 22, 2024
junichi11 added a commit to junichi11/netbeans that referenced this issue May 23, 2024
@junichi11
Don't fold empty arrays apache#7187
006fdfa 
- apache#7187
- Ignore empty arrays
- Add an unit test
junichi11 added a commit to junichi11/netbeans that referenced this issue May 23, 2024
@junichi11
Don't fold empty arrays apache#7187
9520e04 
- apache#7187
- Ignore empty arrays
- Add an unit test
@junichi11 junichi11 mentioned this issue May 23, 2024
Merged
@junichi11 junichi11 linked a pull request May 23, 2024 that will close this issue
Don't fold empty arrays #7187 #7398
Merged
junichi11 added a commit that referenced this issue May 24, 2024
@junichi11
Merge pull request #7398 from junichi11/php-gh-7187-empty-array-folding
66c7486 
Don't fold empty arrays #7187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junichi11 junichi11

Labels
enhancement PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB23
Development

Successfully merging a pull request may close this issue.

Don't fold empty arrays #7187 junichi11/netbeans
3 participants
@junichi11 @troizet @NReib