nimble/host: Optimize characteristics discovery #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can stop characteristics discovery as soon as there are less than 2 attributes left. This means if last characteristic has descriptor (e.g. CCC) we will save single ATT_READ_BY_TYPE_REQ/RSP transaction. As a side-effect we also resume discovery starting from the next handle after last characteristic value handle instead of characteristic declaration handle, but this is ok since there cannot be any atrtibutes (so also characteristic declarations) between characteristic declaration and characteristic value.
|
#AutoPTS run mynewt GATT/CL |
|
Scheduled PR #1885 (comment), board: nrf52, estimated start time: 15:51:39, test case count: 63, estimated duration: 0:31:28 Test cases to be runGATT/CL/GAC/BV-01-CGATT/CL/GAD/BV-01-C GATT/CL/GAD/BV-02-C GATT/CL/GAD/BV-03-C GATT/CL/GAD/BV-04-C GATT/CL/GAD/BV-05-C GATT/CL/GAD/BV-06-C GATT/CL/GAR/BV-01-C GATT/CL/GAR/BI-01-C GATT/CL/GAR/BI-02-C GATT/CL/GAR/BI-04-C GATT/CL/GAR/BI-05-C GATT/CL/GAR/BV-03-C GATT/CL/GAR/BI-06-C GATT/CL/GAR/BI-07-C GATT/CL/GAR/BI-10-C GATT/CL/GAR/BI-11-C GATT/CL/GAR/BV-04-C GATT/CL/GAR/BI-12-C GATT/CL/GAR/BI-13-C GATT/CL/GAR/BI-14-C GATT/CL/GAR/BI-16-C GATT/CL/GAR/BI-17-C GATT/CL/GAR/BV-05-C GATT/CL/GAR/BI-18-C GATT/CL/GAR/BI-19-C GATT/CL/GAR/BI-21-C GATT/CL/GAR/BI-22-C GATT/CL/GAR/BV-06-C GATT/CL/GAR/BV-07-C GATT/CL/GAR/BI-35-C GATT/CL/GAR/BV-08-C GATT/CL/GAR/BV-10-C GATT/CL/GAR/BI-36-C GATT/CL/GAR/BI-38-C GATT/CL/GAR/BI-42-C GATT/CL/GAR/BI-44-C GATT/CL/GAW/BV-01-C GATT/CL/GAW/BV-03-C GATT/CL/GAW/BI-02-C GATT/CL/GAW/BI-03-C GATT/CL/GAW/BI-05-C GATT/CL/GAW/BI-06-C GATT/CL/GAW/BV-05-C GATT/CL/GAW/BI-07-C GATT/CL/GAW/BI-08-C GATT/CL/GAW/BI-09-C GATT/CL/GAW/BI-12-C GATT/CL/GAW/BI-13-C GATT/CL/GAW/BV-06-C GATT/CL/GAW/BV-08-C GATT/CL/GAW/BV-09-C GATT/CL/GAW/BI-32-C GATT/CL/GAW/BI-33-C GATT/CL/GAW/BI-34-C GATT/CL/GAN/BV-01-C GATT/CL/GAN/BV-02-C GATT/CL/GAI/BV-01-C GATT/CL/GAI/BI-01-C GATT/CL/GAS/BV-01-C GATT/CL/GAT/BV-01-C GATT/CL/GAT/BV-02-C GATT/CL/GAT/BV-03-C |
|
AutoPTS Bot results: Failed tests (1)GATT GATT/CL/GAR/BI-05-C FATAL ERRORSuccessful tests (62)GATT GATT/CL/GAC/BV-01-C PASSGATT GATT/CL/GAD/BV-01-C PASS GATT GATT/CL/GAD/BV-02-C PASS GATT GATT/CL/GAD/BV-03-C PASS GATT GATT/CL/GAD/BV-04-C PASS GATT GATT/CL/GAD/BV-05-C PASS GATT GATT/CL/GAD/BV-06-C PASS GATT GATT/CL/GAI/BI-01-C PASS GATT GATT/CL/GAI/BV-01-C PASS GATT GATT/CL/GAN/BV-01-C PASS GATT GATT/CL/GAN/BV-02-C PASS GATT GATT/CL/GAR/BI-01-C PASS GATT GATT/CL/GAR/BI-02-C PASS GATT GATT/CL/GAR/BI-04-C PASS GATT GATT/CL/GAR/BI-06-C PASS GATT GATT/CL/GAR/BI-07-C PASS GATT GATT/CL/GAR/BI-10-C PASS GATT GATT/CL/GAR/BI-11-C PASS GATT GATT/CL/GAR/BI-12-C PASS GATT GATT/CL/GAR/BI-13-C PASS GATT GATT/CL/GAR/BI-14-C PASS GATT GATT/CL/GAR/BI-16-C PASS GATT GATT/CL/GAR/BI-17-C PASS GATT GATT/CL/GAR/BI-18-C PASS (2) GATT GATT/CL/GAR/BI-19-C PASS GATT GATT/CL/GAR/BI-21-C PASS GATT GATT/CL/GAR/BI-22-C PASS (2) GATT GATT/CL/GAR/BI-35-C PASS GATT GATT/CL/GAR/BI-36-C PASS GATT GATT/CL/GAR/BI-38-C PASS GATT GATT/CL/GAR/BI-42-C PASS GATT GATT/CL/GAR/BI-44-C PASS GATT GATT/CL/GAR/BV-01-C PASS GATT GATT/CL/GAR/BV-03-C PASS GATT GATT/CL/GAR/BV-04-C PASS GATT GATT/CL/GAR/BV-05-C PASS GATT GATT/CL/GAR/BV-06-C PASS GATT GATT/CL/GAR/BV-07-C PASS GATT GATT/CL/GAR/BV-08-C PASS GATT GATT/CL/GAR/BV-10-C PASS GATT GATT/CL/GAS/BV-01-C PASS GATT GATT/CL/GAT/BV-01-C PASS (2) GATT GATT/CL/GAT/BV-02-C PASS GATT GATT/CL/GAT/BV-03-C PASS GATT GATT/CL/GAW/BI-02-C PASS GATT GATT/CL/GAW/BI-03-C PASS GATT GATT/CL/GAW/BI-05-C PASS GATT GATT/CL/GAW/BI-06-C PASS GATT GATT/CL/GAW/BI-07-C PASS GATT GATT/CL/GAW/BI-08-C PASS GATT GATT/CL/GAW/BI-09-C PASS GATT GATT/CL/GAW/BI-12-C PASS GATT GATT/CL/GAW/BI-13-C PASS GATT GATT/CL/GAW/BI-32-C PASS GATT GATT/CL/GAW/BI-33-C PASS GATT GATT/CL/GAW/BI-34-C PASS GATT GATT/CL/GAW/BV-01-C PASS GATT GATT/CL/GAW/BV-03-C PASS GATT GATT/CL/GAW/BV-05-C PASS GATT GATT/CL/GAW/BV-06-C PASS GATT GATT/CL/GAW/BV-08-C PASS GATT GATT/CL/GAW/BV-09-C PASS |
|
#AutoPTS run mynewt GATT/CL/GAR/BI-05-C |
|
Scheduled PR #1885 (comment), board: nrf52, estimated start time: 08:20:59, test case count: 1, estimated duration: 0:00:19 Test cases to be runGATT/CL/GAR/BI-05-C |
|
AutoPTS Bot results: Successful tests (1)GATT GATT/CL/GAR/BI-05-C PASS |
sjanc
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can stop characteristics discovery as soon as there are less than 2 attributes left. This means if last characteristic has descriptor (e.g. CCC) we will save single ATT_READ_BY_TYPE_REQ/RSP transaction.
As a side-effect we also resume discovery starting from the next handle after last characteristic value handle instead of characteristic declaration handle, but this is ok since there cannot be any atrtibutes (so also characteristic declarations) between characteristic declaration and characteristic value.