Increase size of some struct fcb members
#3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component: Flash Circular Buffer Change the type of sector_cnt and scratch_cnt from a uint8_t to a uint16_t, allowing for counts > 255.
|
@kasjer Really weird thing - the failure in the style check does not show up when I try to edit the file. Have you seen this before? |
|
@k-bharadwaj no worry it's look good to me. I'll merge it in a minute. Thanks for contribution. |
kasjer
approved these changes
Jul 14, 2023
|
@kasjer Thanks, appreciated! :) We're using a 4MB QSPI flash with 1K sectors which was overflowing the sector_cnt failing fcb_init. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component: Flash Circular Buffer
Change the type of sector_cnt and scratch_cnt from a uint8_t to a uint16_t, allowing for counts > 255.