feat(sheet): Lazy update sends uneccessary column headers

issue: TOBAGO-2368
apache · Dec 21, 2024 · 0e8f3da · 0e8f3da
1 parent f319eb1
commit 0e8f3da
Showing 1 changed file with 36 additions and 33 deletions.
diff --git a/...re/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java b/...re/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
@@ -433,33 +433,35 @@ private void encodeTableBody(final FacesContext facesContext, final AbstractUISh
     final boolean showHeader = sheet.isShowHeader();
     final Markup sheetMarkup = sheet.getMarkup() != null ? sheet.getMarkup() : Markup.NULL;
 
-    final UIComponent before = sheet.getFacet(Facets.BEFORE);
-    if (before != null) {
-      before.encodeAll(facesContext);
-    }
-
-    if (showHeader && !autoLayout) {
-      // if no autoLayout, we render the header in a separate table.
-      writer.startElement(HtmlElements.HEADER);
-      writer.startElement(HtmlElements.TABLE);
-      writer.writeAttribute(HtmlAttributes.CELLSPACING, "0", false);
-      writer.writeAttribute(HtmlAttributes.CELLPADDING, "0", false);
-      writer.writeAttribute(HtmlAttributes.SUMMARY, "", false);
-      writer.writeClassAttribute(
-          BootstrapClass.TABLE,
-          sheetMarkup.contains(Markup.DARK) ? BootstrapClass.TABLE_DARK : null,
-          sheetMarkup.contains(Markup.BORDERED) ? BootstrapClass.TABLE_BORDERED : null,
-          sheetMarkup.contains(Markup.SMALL) ? BootstrapClass.TABLE_SM : null,
-          TobagoClass.TABLE_LAYOUT__FIXED);
+    boolean nonLazyUpdate = !sheet.isLazyUpdate(facesContext);
+    if (nonLazyUpdate) {
+      final UIComponent before = sheet.getFacet(Facets.BEFORE);
+      if (before != null) {
+        before.encodeAll(facesContext);
+      }
 
-      writeColgroup(writer, columnWidths, columns, true);
-      writer.startElement(HtmlElements.THEAD);
-      encodeHeaderRows(facesContext, sheet, writer, columns);
-      writer.endElement(HtmlElements.THEAD);
-      writer.endElement(HtmlElements.TABLE);
-      writer.endElement(HtmlElements.HEADER);
+      if (showHeader && !autoLayout) {
+        // if no autoLayout, we render the header in a separate table.
+        writer.startElement(HtmlElements.HEADER);
+        writer.startElement(HtmlElements.TABLE);
+        writer.writeAttribute(HtmlAttributes.CELLSPACING, "0", false);
+        writer.writeAttribute(HtmlAttributes.CELLPADDING, "0", false);
+        writer.writeAttribute(HtmlAttributes.SUMMARY, "", false);
+        writer.writeClassAttribute(
+            BootstrapClass.TABLE,
+            sheetMarkup.contains(Markup.DARK) ? BootstrapClass.TABLE_DARK : null,
+            sheetMarkup.contains(Markup.BORDERED) ? BootstrapClass.TABLE_BORDERED : null,
+            sheetMarkup.contains(Markup.SMALL) ? BootstrapClass.TABLE_SM : null,
+            TobagoClass.TABLE_LAYOUT__FIXED);
+
+        writeColgroup(writer, columnWidths, columns, true);
+        writer.startElement(HtmlElements.THEAD);
+        encodeHeaderRows(facesContext, sheet, writer, columns);
+        writer.endElement(HtmlElements.THEAD);
+        writer.endElement(HtmlElements.TABLE);
+        writer.endElement(HtmlElements.HEADER);
+      }
     }
-
     writer.startElement(HtmlElements.DIV);
     writer.writeClassAttribute(TobagoClass.BODY);
 
@@ -476,19 +478,20 @@ private void encodeTableBody(final FacesContext facesContext, final AbstractUISh
         sheetMarkup.contains(Markup.SMALL) ? BootstrapClass.TABLE_SM : null,
         !autoLayout ? TobagoClass.TABLE_LAYOUT__FIXED : null);
 
-    if (showHeader && autoLayout) {
-      writer.startElement(HtmlElements.THEAD);
-      encodeHeaderRows(facesContext, sheet, writer, columns);
-      writer.endElement(HtmlElements.THEAD);
-    }
-    if (!autoLayout) {
-      writeColgroup(writer, columnWidths, columns, false);
+    if (nonLazyUpdate) {
+      if (showHeader && autoLayout) {
+        writer.startElement(HtmlElements.THEAD);
+        encodeHeaderRows(facesContext, sheet, writer, columns);
+        writer.endElement(HtmlElements.THEAD);
+      }
+      if (!autoLayout) {
+        writeColgroup(writer, columnWidths, columns, false);
+      }
     }
     // Print the Content
     if (LOG.isDebugEnabled()) {
       LOG.debug("first = " + sheet.getFirst() + "   rows = " + sheet.getRows());
     }
-
     writer.startElement(HtmlElements.TBODY);
 
     final String var = sheet.getVar();