Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

move concurrent/identity blocks to contrib #9427

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

szha
Copy link
Member

@szha szha commented Jan 15, 2018

Description

Move Concurrent/HybridConcurrent/Identity blocks from custom_layers in model zoo to gluon.contrib. Identity block simply passes the input through. Concurrent blocks can be used to concatenate outputs from child blocks on the specified axis. These blocks are useful in implementing residual paths commonly seen in networks through constructor.

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Move Concurrent/HybridConcurrent/Identity blocks from custom_layers in model zoo to gluon.contrib

@szha szha requested a review from zhreshold January 15, 2018 01:28
@zhreshold zhreshold merged commit 6dcb0eb into apache:master Jan 15, 2018
@szha szha deleted the gluon_contrib branch January 15, 2018 06:46
CodingCat pushed a commit to CodingCat/mxnet that referenced this pull request Jan 16, 2018
yuxiangw pushed a commit to yuxiangw/incubator-mxnet that referenced this pull request Jan 25, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants