Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

refactor cachedop #6735

Merged
merged 1 commit into from
Jun 21, 2017
Merged

refactor cachedop #6735

merged 1 commit into from
Jun 21, 2017

Conversation

piiswrong
Copy link
Contributor

@piiswrong piiswrong commented Jun 18, 2017

@sergeykolychev I refactored CachedOp and revered changes in perl.

@sergeykolychev
Copy link
Contributor

@piiswrong are you ok with me just redoing the cachedop for Perl to make it compatible with your changes without​ yanking whole pull away ?

@sergeykolychev
Copy link
Contributor

On other hand the errors in the Perl tests are superficial , no tests failed just the number of tests run need adjustment , I will create a pull against this pull with the tests fix and will worry about the cachedop later. Do you plan to redo it or you consider it's stable this time ? I'll wait with porting of your changes if it's still in flux. Thanks

@sergeykolychev
Copy link
Contributor

@piiswrong piiswrong#4 this fixes the perl tests on this branch.

@piiswrong
Copy link
Contributor Author

I only removed the cachedop for perl.

Its probably better to wait for a couple weeks before reintroducing it to perl.

Thanks

@sergeykolychev
Copy link
Contributor

Ok, sure, I'll wait.

@sergeykolychev
Copy link
Contributor

@piiswrong looks like my test number fix got somehow removed from your branch, you'll need to reapply.

revert cachedop for perl

fix
t st
imt qprove error message

ci

fix

fix

fix
@piiswrong piiswrong merged commit 3ceb6d2 into apache:master Jun 21, 2017
Guneet-Dhillon pushed a commit to Guneet-Dhillon/mxnet that referenced this pull request Sep 13, 2017
revert cachedop for perl

fix
t st
imt qprove error message

ci

fix

fix

fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants