This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update documentation for mxnet.ndarray.GridGenerator. #6430
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,11 +32,9 @@ Operator *GridGeneratorProp::CreateOperatorEx(Context ctx, std::vector<TShape> * | |
DMLC_REGISTER_PARAMETER(GridGeneratorParam); | ||
|
||
MXNET_REGISTER_OP_PROPERTY(GridGenerator, GridGeneratorProp) | ||
.add_argument("data", "NDArray-or-Symbol", "Input data to the GridGeneratorOp.") | ||
.describe("if transformation type is affine, data is affine matrix : (batch, 6)") | ||
.describe("if transformation type is warp, data is optical flow : (batch, 2, h, w)") | ||
.add_argument("data", "NDArray-or-Symbol", "Input data to the function.") | ||
.add_arguments(GridGeneratorParam::__FIELDS__()) | ||
.describe("Generates sampling grid for bilinear sampling."); | ||
.describe("Generates 2D sampling grid for bilinear sampling."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Explain more. Link to the paper. explain what this op is for & how it should be used. |
||
|
||
} // namespace op | ||
} // namespace mxnet |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still hard to understand. What's affine matrix? what's optical flow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I here assume reader has backgrounds about common matrices.
I will attach more description for affine transform , but as for optical flow, detailed explanation can take pages, personally prefer a link to wiki.