Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixed the trailing L problem of hex(...) #555

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Conversation

sxjscience
Copy link
Member

Using hex for 16-bit string conversion will cause the Trailing L Problem for 64-bit value. See #545 for more detail.

@piiswrong
Copy link
Contributor

Can someone verify that this works for both julia & python before we merge?

@vchuravy
Copy link
Contributor

This only changes code on the python side of things, so no need for checking Julia

I can confirm that the python side works, by running the numpy_softmax example.

@pluskid
Copy link
Contributor

pluskid commented Nov 12, 2015

This will not affect Julia side as the native operator for Julia is still pending for some refactoring of the async callback in libmxnet. In the current interface it is not possible to implement. On my phone but can provide reference to existing issues if needed.

@vchuravy
Copy link
Contributor

See dmlc/MXNet.jl#16 for reference.

tqchen added a commit that referenced this pull request Nov 12, 2015
Fixed the trailing L problem of hex(...)
@tqchen tqchen merged commit d5d1d72 into apache:master Nov 12, 2015
@sxjscience sxjscience deleted the pr_branch branch November 13, 2015 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants