This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[master] Fix issue with even number of channels in BatchNorm #20907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @piotrwolinski-intel , Thanks for submitting the PR
CI supported jobs: [unix-cpu, website, centos-cpu, centos-gpu, edge, unix-gpu, windows-gpu, miscellaneous, sanity, clang, windows-cpu] Note: |
mseth10
added
the
pr-awaiting-testing
mseth10
added
pr-work-in-progress
|
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu] |
|
Jenkins CI successfully triggered : [unix-cpu, unix-gpu, centos-gpu] |
|
@mxnet-bot run ci [website ] |
|
Jenkins CI successfully triggered : [website] |
mseth10
added
pr-awaiting-testing
piotrwolinski-intel
requested review from
szha and
aaronmarkham
as code owners
mseth10
added
pr-awaiting-testing
piotrwolinski-intel
force-pushed
the
piotrwolinski/batchnorm-fix-master
branch
from
be1aaf1
to
0510abc
Compare
mseth10
added
pr-work-in-progress
|
@mxnet-bot run ci [edge, unix-cpu, windows-gpu] |
|
Jenkins CI successfully triggered : [edge, unix-cpu, windows-gpu] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu] |
mseth10
added
pr-awaiting-testing
bgawrych
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal of this PR is to prevent bug with BatchNorm, that was seen on other versions (here for instance).
Fix is done by calling oneDNN implementations via
DNNLRunmethod, not directly.