This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Enable float32 data type in linalg cholesky test #20508
Open
mozga-intel
wants to merge
7
commits into
apache:master
Choose a base branch
from
mozga-intel:mozga-intel/linalg_cholesky_float32_support_enable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable float32 data type in linalg cholesky test #20508
mozga-intel
wants to merge
7
commits into
apache:master
from
mozga-intel:mozga-intel/linalg_cholesky_float32_support_enable
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @mozga-intel , Thanks for submitting the PR
CI supported jobs: [website, clang, sanity, unix-cpu, centos-cpu, miscellaneous, windows-gpu, edge, centos-gpu, windows-cpu, unix-gpu] Note: |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 10, 2021
6 tasks
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 10, 2021
…cholesky_float32_support_enable
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 13, 2021
@mxnet-bot run ci [all] |
Jenkins CI successfully triggered : [clang, unix-gpu, unix-cpu, centos-gpu, website, windows-cpu, edge, centos-cpu, windows-gpu, sanity, miscellaneous] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 25, 2021
Looks like the atol and rtol need to be adjusted for lower precision cholesky op. |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 6, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Apr 2, 2022
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Apr 16, 2022
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Apr 27, 2022
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #20505 . The Cholesky test on the current master uses only float64 data type. Checking Float32 data type is disabled. Is this intended or negligence? Here is a quick fix to check on float32 data type.
Checklist
Essentials
Changes
Comments