Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x]Update git repo reference #20496

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Aug 7, 2021

Description

Action item 7 from #20475. Update git repo reference from https://github.com/dmlc/mxnet to https://github.com/apache/mxnet. Fix broken links

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, website, centos-cpu, unix-gpu, sanity, miscellaneous, windows-gpu, unix-cpu, edge, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 7, 2021
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using the link https://github.com/apache/mxnet as it will redirect to incubator-mxnet address and we won't have to change it again.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Aug 9, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 9, 2021
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these links, LGTM!

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 9, 2021
@mseth10 mseth10 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Aug 9, 2021
@josephevans josephevans merged commit 1cf2fe5 into apache:v1.9.x Aug 10, 2021
@waytrue17 waytrue17 mentioned this pull request Aug 10, 2021
6 tasks
barry-jin pushed a commit to barry-jin/incubator-mxnet that referenced this pull request Sep 24, 2021
@barry-jin barry-jin mentioned this pull request Sep 24, 2021
4 tasks
barry-jin added a commit that referenced this pull request Sep 28, 2021
* Port #20496

* v1.x -> master

Co-authored-by: waytrue17 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants