This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.0] Add cpp-package #20131
[2.0] Add cpp-package #20131
Changes from 46 commits
c0c4a0e
b60808f
ce056a0
bc62d6b
9fab1a9
b6a16d9
0b90b83
b3d121e
b3075a9
c6a40a2
64d1111
b91d00e
b12fb9a
43dc452
ec76a6c
2271657
1993a48
b084c15
fedef00
730d5eb
21007f4
e2aaec1
c06334b
992d3d6
8e4c0ba
b1bd450
64e2d16
0ba0a4d
7e9256a
f1ff96c
6540581
d055afd
cf104e5
ad4c370
887bb5a
65c5d12
63fc6ad
1f20a20
c6fc5cb
d09dfec
f8350b3
f016683
748941f
d82e085
605e7ac
e49df4a
6bddda2
e9d8b45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason for that. cpp-package depends only on libmxnet.so C APIs. It would be better to keep a separate CMakeLists.txt for the cpp-package with the only requirement to find libmxnet.so. This implies removing the
USE_CPP_PACKAGE
in the main CMakeLists.txtThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. Let me update the documentation.