Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] pass version param #19982

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[v1.x] pass version param #19982

merged 1 commit into from
Mar 5, 2021

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Mar 5, 2021

This PR enables version name to be passed down from release pipeline for naming docker images.

Also removes multiple tagging for same image.

@mseth10 mseth10 requested a review from Zha0q1 March 5, 2021 02:41
@mseth10 mseth10 requested a review from szha as a code owner March 5, 2021 02:41
@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, miscellaneous, unix-cpu, edge, centos-cpu, website, clang, sanity, windows-cpu, unix-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2021
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseth10 mseth10 merged commit 9a2a502 into apache:v1.x Mar 5, 2021
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 5, 2021
@mseth10 mseth10 mentioned this pull request Mar 6, 2021
mseth10 added a commit that referenced this pull request Mar 8, 2021
… pipeline (#19989)

* [v1.x] Fix nightly CD for python docker image releases (#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775)

* Fix nightly CD for python docker image releases (#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
mseth10 added a commit to mseth10/incubator-mxnet that referenced this pull request Mar 15, 2021
… pipeline (apache#19989)

* [v1.x] Fix nightly CD for python docker image releases (apache#19774)

* [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775)

* Fix nightly CD for python docker image releases (apache#19772)

* install wget

* test cd docker in ci

* install docker

* install python3-dev and gcc

* remove docker testing from ci

* remove python3-dev

* ecr target

* skip build test

* adding back python3-dev for make

* remove dynamic and pypi stages for testing

* install build-essential

* install zlib

* update python version

* update ld library path

* install openssl

* update test packages for python3.7

* remove call to deleted safe_docker_run.py

* hardcode region for public ecr repo

* use deadsnakes to install python

* revert dependency change

* refactor ecr login

* update ecr repo jenkins global var

* cleanup

* update docker authentication

* add ecr repo

* add back pypi and tests

* remove unused libmxnet pipeline

* update cu112 base docker

* update base docker images to ub18

* differentiate tag prefix for v1.x

Co-authored-by: Sheng Zha <[email protected]>

* pass version param (apache#19982)

* remove cu112 changes

Co-authored-by: Sheng Zha <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants