This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @mseth10 , Thanks for submitting the PR
CI supported jobs: [windows-gpu, miscellaneous, unix-cpu, edge, centos-cpu, website, clang, sanity, windows-cpu, unix-gpu, centos-gpu] Note: |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Mar 5, 2021
Zha0q1
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mseth10
added a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Mar 5, 2021
Merged
mseth10
added a commit
that referenced
this pull request
Mar 8, 2021
… pipeline (#19989) * [v1.x] Fix nightly CD for python docker image releases (#19774) * [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (#17775) * Fix nightly CD for python docker image releases (#19772) * install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18 * differentiate tag prefix for v1.x Co-authored-by: Sheng Zha <[email protected]> * pass version param (#19982) * remove cu112 changes Co-authored-by: Sheng Zha <[email protected]>
mseth10
added a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Mar 15, 2021
… pipeline (apache#19989) * [v1.x] Fix nightly CD for python docker image releases (apache#19774) * [CD] switch CD_RELEASE_JOB_NAME from global env var to job argument (apache#17775) * Fix nightly CD for python docker image releases (apache#19772) * install wget * test cd docker in ci * install docker * install python3-dev and gcc * remove docker testing from ci * remove python3-dev * ecr target * skip build test * adding back python3-dev for make * remove dynamic and pypi stages for testing * install build-essential * install zlib * update python version * update ld library path * install openssl * update test packages for python3.7 * remove call to deleted safe_docker_run.py * hardcode region for public ecr repo * use deadsnakes to install python * revert dependency change * refactor ecr login * update ecr repo jenkins global var * cleanup * update docker authentication * add ecr repo * add back pypi and tests * remove unused libmxnet pipeline * update cu112 base docker * update base docker images to ub18 * differentiate tag prefix for v1.x Co-authored-by: Sheng Zha <[email protected]> * pass version param (apache#19982) * remove cu112 changes Co-authored-by: Sheng Zha <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables version name to be passed down from release pipeline for naming docker images.
Also removes multiple tagging for same image.